Closed juligasa closed 2 years ago
marten-seemann
commented
2 years ago We probably need to improve static relay handling (also in #1587).
Given that this PR is already reviewed and approved and just waiting for the v0.21 to ship before getting merged, we won't make any changes to it. We'd be happy to accept follow-up PRs to #1587 though (feel free to craft something on top that branch right now, no need to wait until it's actually merged).
juligasa
commented
2 years ago Great! I will test that branch and make changes there, if needed. But if that PR is already reviewed, why doesn't it make it to the v0.21 release?
MarcoPolo
commented
2 years ago We already started smoke testing the 0.21 release and wanted to make that release with minimal changes. But the 0.22 release will be right around the corner :)
BigLep
commented
2 years ago We expect this will be resolved in 0.22 when https://github.com/libp2p/go-libp2p/pull/1587 lands.
marten-seemann
commented
2 years ago
Problem I have a relay v2 running on a public accessible server, and an p2p application behind a NAT that uses libp2p. We use the option
autorelay.WithStaticRelaysin the client app so the autorelay knows where to find a relay to do hole punching with other peers. It connects and start reserving slots without problem. If for some reason the relay on the server gets reseted, then the autorelay deletes that relay with the log:2022-07-06T17:02:19.491+0200 DEBUG autorelay autorelay/relay_finder.go:142 disconnected from relay {"id": "XXXX"}and after that never tries to reconnect to that relay. Expected behavior I would expect that autorelay sends that failling relay to backoff the same way when it fails to connect. Related PR's: #1587Version Information