search

libp2p / go-msgio

simple package to r/w length-delimited slices.
MIT License
12 stars 12 forks source link

remove "Chan" type #23

Closed Stebalien closed 3 years ago

Stebalien commented 3 years ago

This type isn't used anywhere and doesn't conform to go's ReadFrom/WriteTo interfaces. Unfortunately, go vet doesn't have any way to say "please ignore this error", so our options were to:

  1. Fix it.
  2. Delete it.

Given that it isn't used and hasn't been for years, I opted for the latter. We can always re-implement it later if we need it (and bring it up to do date with idiomatic go).

Stebalien commented 3 years ago

This will let us test with unified CI.