search

libp2p / go-reuseport

reuse tcp/udp ports in golang
ISC License
766 stars 108 forks source link

fix: add wasm build tag to wasm module #70

Closed Kubuxu closed 5 years ago

Kubuxu commented 5 years ago

It is not strictly needed but in cases of builds with Go older than 1.11 it significantly improves error message.

anacrolix commented 5 years ago

I wonder if you could get fancier and put // +build !go1.11,wasm?

Kubuxu commented 5 years ago

There is no reason to do so.

anacrolix commented 5 years ago

It was a question, but technically you're occluding future behaviour changes to the Go tooling.