search

libp2p / js-libp2p-mdns

libp2p MulticastDNS Peer Discovery
https://libp2p.io
Other
52 stars 17 forks source link

[feature/multicast-dns] Added support for custom DNS server IP #142

Closed rennokki closed 1 year ago

rennokki commented 1 year ago

I need to test my app for a custom DNS server (that's not the default one), and multicastdns() does not supports it.

I've added the ip option according to the multicast-dns dependency.

achingbrain commented 1 year ago

@rennokki thanks - can you please add a test to this PR

rennokki commented 1 year ago

@achingbrain Finally had some time to update the PR :)

achingbrain commented 1 year ago

Thanks!

rennokki commented 1 year ago

@achingbrain Seems like the release broke: https://github.com/libp2p/js-libp2p-mdns/actions/runs/3275565715/jobs/5390636627

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

achingbrain commented 1 year ago

Thanks for the prod, looks like GitHub was having a moment, all good now!