chore: peer-discovery not using peer-info

libp2p / js-libp2p-mdns

libp2p MulticastDNS Peer Discovery

https://libp2p.io

Other

51 stars 17 forks source link

chore: peer-discovery not using peer-info #90

Closed vasco-santos closed 4 years ago

vasco-santos commented 4 years ago

In the context of deprecating peer-info as described on libp2p/js-libp2p#589, this PR changes the peer-discovery interface to emit an object containing an id property and a multiaddrs property.

This adds a multiaddrs property to the constructor for now. This should receive libp2p and access the libp2p listening multiaddrs instead

BREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info

Needs:

[x] libp2p/js-libp2p-interfaces#41

vasco-santos commented 4 years ago

I addressed the review and also fixed the Querier parameters bug

vasco-santos commented 4 years ago

Changed README to use peerData instead of peerInfo for events and peerId instead of peerInfo for the MDNS constructor. It should all correct now

jacobheun commented 4 years ago

Beta tag released:

dist-tags:
beta: 0.14.0    latest: 0.13.3