search

libp2p / js-libp2p-mplex

JavaScript implementation of https://github.com/libp2p/mplex
https://libp2p.io
Other
51 stars 30 forks source link

deps(dev): Upgrade aegir to 38.1.7 #257

Closed maschad closed 1 year ago

maschad commented 1 year ago

Also reverting typescript to 4.9.5 because a3590af093dee73c873aef1539bc8d81b0d61b08 upgraded it, but aegir depends on eslint-plugin-etc ( as well as eslint-config-ipfs which also depends on eslint-plugin-etc) which is incompatible with TS5 atm https://github.com/cartant/eslint-plugin-etc/issues/53.

achingbrain commented 1 year ago

Why is there a direct dep on typescript here? Is it just an old mistake?

maschad commented 1 year ago

Not a direct dep, but currently master is failing because of an indirect dep on eslint-plugin-etc which is a peerDep of aegir ( I should have ran this test before merging https://github.com/libp2p/js-libp2p-mplex/pull/256) so essentially we can't use aegir with TS5 yet.

achingbrain commented 1 year ago

Hmm, still not sure why there's a typescript dep here at all, there's nothing special or unique about the repo setup, I think it's just been hanging around for ages and was never removed.

maschad commented 1 year ago

I think I misunderstood the original comment 😅 thanks!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 7.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: