libp2p / js-libp2p-stardust

A better ws-star implementation
8 stars 4 forks source link

Should stardust be a reliable address #22

Open vasco-santos opened 4 years ago

vasco-santos commented 4 years ago

Should stardust be usable on reliable addresses, or just ws/wss, or even just wss.

Follow up of #14 discussions. If yes, we should also add this to mafmt module

cc @mkg20001 @jacobheun

mkg20001 commented 4 years ago

My opinion is that (since the security concern is mainly DOS) it's not wrong to allow it, yet there should be a way we make it clear to the user that it might be an issue that way.

Or stardust could check if the address has an encryption layer (for ex wss) and add one if necessary (using any of the libp2p crypto layers). We could accomplish this by adding secio+plaintext to the server and then using either a plaintext or secio upgrader on the client.