Tests fail to finish without aegir exit

libp2p / js-libp2p-webrtc-star

libp2p WebRTC transport that includes a discovery mechanism provided by the signalling-star

https://libp2p.io

Other

320 stars 96 forks source link

Tests fail to finish without aegir exit #364

Closed vasco-santos closed 2 years ago

vasco-santos commented 3 years ago

There are further tests that fail to finish, I think node-wrtc is failing to close connections properly so I added --exit to the test run to simulate the previous behaviour of aegir but this really needs fixing.

@achingbrain in https://github.com/libp2p/js-libp2p-webrtc-star/pull/362

lidel commented 3 years ago

waiting for fix in node-wrtc
we may speed it up by creating repro case (@achingbrain has more context)

achingbrain commented 2 years ago

This is sort of fixed now, by adding these lines

More context: https://github.com/node-webrtc/node-webrtc/issues/636#issuecomment-774171409