search

libp2p / js-libp2p-webrtc-star

libp2p WebRTC transport that includes a discovery mechanism provided by the signalling-star
https://libp2p.io
Other
320 stars 96 forks source link

fix: pass abort signal to upgrader #389

Closed achingbrain closed 2 years ago

achingbrain commented 2 years ago

In order to abort in-progress dials and not leak memory, the abort signal must be passed to the upgrader in order for it to be passed on to mss and noise.

Refs: https://github.com/libp2p/js-libp2p/pull/1072

achingbrain commented 2 years ago

This is the wrong fix, see explanation in https://github.com/libp2p/js-libp2p/pull/1072#issuecomment-1000844078 - proper fix here: https://github.com/alanshaw/abortable-iterator/pull/15