search

libp2p / js-libp2p-websocket-star-rendezvous

The rendezvous service for libp2p-websocket-star enabled nodes meet and talk with each other
MIT License
24 stars 16 forks source link

Unidentified memory leak #12

Closed victorb closed 4 years ago

victorb commented 6 years ago

We're running one instance of the ws-star signal server which nodes can use as they wish.

It stopped working today, because it was killed by the OS. 

[6706002.171533] Out of memory: Kill process 11669 (node) score 742 or sacrifice child
[6706002.173519] Killed process 11669 (node) total-vm:2703876kB, anon-rss:1509380kB, file-rss:0kB

Looking at the application logs, there is bunch of warnings about memory leaks.

2018-01-23T17:00:34.252910783Z app[web.1]: (node:183) Warning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit
2018-01-23T17:00:35.039866402Z app[web.1]: (node:183) Warning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit
2018-01-23T17:04:44.695474552Z app[web.1]: (node:183) Warning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit
2018-01-23T17:07:19.590937032Z app[web.1]: Killed
2018-01-23T17:07:19.627303917Z app[web.1]:
2018-01-23T17:07:19.640953504Z app[web.1]: npm ERR! Linux 4.4.0-98-generic
2018-01-23T17:07:19.641868418Z app[web.1]: npm ERR! argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "run" "start"
2018-01-23T17:07:19.641903722Z app[web.1]: npm ERR! node v6.12.1
2018-01-23T17:07:19.642157992Z app[web.1]: npm ERR! npm  v3.10.10
2018-01-23T17:07:19.642442977Z app[web.1]: npm ERR! code ELIFECYCLE
2018-01-23T17:07:19.642664576Z app[web.1]: npm ERR! libp2p-websocket-star-rendezvous@0.2.1 start: `node src/bin.js`
2018-01-23T17:07:19.642815440Z app[web.1]: npm ERR! Exit status 137
2018-01-23T17:07:19.642983118Z app[web.1]: npm ERR!
2018-01-23T17:07:19.643133974Z app[web.1]: npm ERR! Failed at the libp2p-websocket-star-rendezvous@0.2.1 start script 'node src/bin.js'.
2018-01-23T17:07:19.643279655Z app[web.1]: npm ERR! Make sure you have the latest version of node.js and npm installed.
2018-01-23T17:07:19.643424626Z app[web.1]: npm ERR! If you do, this is most likely a problem with the libp2p-websocket-star-rendezvous package,
2018-01-23T17:07:19.643573816Z app[web.1]: npm ERR! not with npm itself.
2018-01-23T17:07:19.643756549Z app[web.1]: npm ERR! Tell the author that this fails on your system:
2018-01-23T17:07:19.643908058Z app[web.1]: npm ERR!     node src/bin.js
2018-01-23T17:07:19.644058402Z app[web.1]: npm ERR! You can get information on how to open an issue for this project with:
2018-01-23T17:07:19.644346075Z app[web.1]: npm ERR!     npm bugs libp2p-websocket-star-rendezvous
2018-01-23T17:07:19.644516845Z app[web.1]: npm ERR! Or if that isn't available, you can get their info via:
2018-01-23T17:07:19.644615402Z app[web.1]: npm ERR!     npm owner ls libp2p-websocket-star-rendezvous
2018-01-23T17:07:19.644708075Z app[web.1]: npm ERR! There is likely additional logging output above.
2018-01-23T17:07:19.665476680Z app[web.1]:
2018-01-23T17:07:19.666819307Z app[web.1]: npm ERR! Please include the following file with any support request:
2018-01-23T17:07:19.666960754Z app[web.1]: npm ERR!     /app/npm-debug.log

The line Warning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit has been repeated once every five minutes for as long as we keep the logs.

mkg20001 commented 6 years ago

I don't know if that should get fixed as this package is currently being rewritten anyway. See #11 The newer version should consume less memory because it's no longer using socket.io