feat: add transport listener

libp2p / js-libp2p-webtransport

WebTranport module that libp2p uses and that implements the interface-transport spec

Other

15 stars 5 forks source link

feat: add transport listener #31

Closed achingbrain closed 3 months ago

achingbrain commented 1 year ago

Uses @fails-components/webtransport to implement a listener for this transport in node.

Depends on:

[ ] Removal of console.log from @fails-components/webtransport
[ ] Removal of segfaults from @fails-components/webtransport
[ ] Fast event loop start/stop in @fails-components/webtransport
[x] https://github.com/libp2p/js-libp2p/pull/1502
[x] https://github.com/libp2p/js-libp2p/pull/1474
[ ] https://github.com/fails-components/webtransport/pull/130

marcus-pousette commented 1 year ago

Any updates on this? Capability having a listener would help me a lot since I am only integrating with libp2p-js atm.

p-shahi commented 1 year ago

Update on this PR: @marcus-pousette This feature is going to be added but when we ship it, it will likely be an experimental feature (since we may want to swap out the internal implementation i.e. fails-component at a later date)

There's one last PR in the fails-component/webtransport https://github.com/fails-components/webtransport/pull/130 that ensures the same unit tests are run in node as well as the browser (to verify client side behaves the same). Once that's in place and a review is done, we'll be able to release this experimentally

MarcoPolo commented 1 year ago

I've removed my review request to tidy up my pending reviews, but please tag me when this is out of draft.

dhuseby commented 3 months ago

go here: https://github.com/libp2p/js-libp2p/pull/2422