fix: allow dialling ip6 webtransport addresses

libp2p / js-libp2p-webtransport

WebTranport module that libp2p uses and that implements the interface-transport spec

Other

15 stars 5 forks source link

fix: allow dialling ip6 webtransport addresses #60

Closed SgtPooki closed 1 year ago

SgtPooki commented 1 year ago

fix: use valid rfc3986 ipv6 host syntax

achingbrain commented 1 year ago

Just seen this in the wild I think:

Error: Failed to construct 'WebTransport': The URL 'https://2001:818:e338:5300:4a21:bff:fe2e:bc0:34001/.well-known/libp2p-webtransport?type=noise' is invalid.
at WebTransport.dial...

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.11 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

MarcoPolo commented 1 year ago

Isn't this going to be an issue anywhere we dial ipv6 addresses?

SgtPooki commented 1 year ago

Isn't this going to be an issue anywhere we dial ipv6 addresses?

With JS, yep. The URL constructor requires the brackets for ip6