search

libp2p / js-libp2p-webtransport

WebTranport module that libp2p uses and that implements the interface-transport spec
Other
15 stars 5 forks source link

CI: Downgrade Go version #67

Closed maschad closed 1 year ago

maschad commented 1 year ago

These failures on CI suggest that the version of quic-go bing used can't be built on Go 1.20 yet. Should we downgrade it to a compatible version?

achingbrain commented 1 year ago

This is fixed now but it's almost certainly going to happen again.

Our options are:

  1. Update go-libp2p-daemon to the latest libp2p which will give it webtransport support, then we can use a precompiled binary and not have to build the webtransport server in this repo from source - https://github.com/libp2p/go-libp2p-daemon/pull/281
  2. Finish the node webtransport listener and remove the go parts of this repo - https://github.com/libp2p/js-libp2p-webtransport/pull/31

My preference is for 2, but 1 might be faster.

maschad commented 1 year ago

Seeing as the go-libp2p-daemon's libp2p version is not going to be actively updated by design, I would say that we should invest the effort in 2 as well to remove it as a dependency.

p-shahi commented 1 year ago

closing in favor of https://github.com/libp2p/js-libp2p-webtransport/issues/75

MarcoPolo commented 1 year ago

Option 3, which is the simplest, is to pin the version of Go.

achingbrain commented 1 year ago

The reason that wasn't added as an option above is that it means adding go config to every JS repo, which didn't feel like a natural thing to do.