fix: typescript enums need to be value-compatible - Githubissues

libp2p / js-libp2p

The JavaScript Implementation of libp2p networking stack.

https://libp2p.io

Other

2.31k stars 442 forks source link

fix: typescript enums need to be value-compatible #2433

Closed achingbrain closed 7 months ago

achingbrain commented 7 months ago

As of TypeScript 5.4.x enums need to have the same values to be compatible so re-use the exported enum from the message definition.

Refs: https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/#new-enum-assignability-restrictions

Change checklist

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[ ] I have added tests that prove my fix is effective or that my feature works