Closed SgtPooki closed 3 months ago
Also, the check is checking >=, and if your limit is 1, that will prevent ANY outbound protocol streams. Is this intended? should we be comparing with only > ?
No, because the stream has been opened already so at this point we are above the limit.
That is, when we carry out multistream select, and we support multiple stream protocols, we don't know ahead of time which one will be selected. We have to let the stream open, negotiate a protocol, then carry out the check. We could compare with ===
instead, but the >=
is slightly safer.
Title
fix: upgrader error msg shows current/max
Description
Provides more information in the error message so users can better understand the error state.
Notes & open questions
This error message is not super helpful for debugging. What's the overage amount?
Also, the check is checking
>=
, and if your limit is 1, that will prevent ANY outbound protocol streams. Is this intended? should we be comparing with only>
?Change checklist