search

libp2p / js-libp2p

The JavaScript Implementation of libp2p networking stack.
https://libp2p.io
Other
2.27k stars 435 forks source link

Circuit Relay v2 should not publish routing key without public addresses #2500

Closed achingbrain closed 2 months ago

achingbrain commented 3 months ago

If a node has no publicly diallable non-relay addresses it shouldn't publish a provider record saying it is a circuit relay server, much like kad-dht requires public addresses to become a server.

The JS implementation may not do this, but it needs double-checking because I think I saw a provider record for a JS peer that only had relay addresses.

achingbrain commented 2 months ago

Closing in favour of #2545