libp2p / js-peer-id

peer-id implementation in JavaScript. Deprecated; use https://github.com/libp2p/js-libp2p-peer-id instead.
https://github.com/libp2p/js-libp2p-peer-id
MIT License
80 stars 44 forks source link

Add a typescript types declaration file of libp2p/js-peer-id. #77

Closed pboymt closed 6 years ago

pboymt commented 6 years ago

I had test it, run well.

dryajov commented 6 years ago

Thanks for the contribution!

However, I believe that this is probably better placed under the https://github.com/DefinitelyTyped/DefinitelyTyped. I would also suggest to take a look at the https://github.com/ipfs/js-ipfs/issues/1260, where our flow effort is being undertaken. I believe that this might have a lot of overlap with that effort.

In any case, great job!

daviddias commented 6 years ago

Thanks @pboymt. We have decided to move ahead with Flow (track: https://github.com/ipfs/js-ipfs/issues/1260). Closing this one //cc @vmx