search

libp2p / js-peer-id

peer-id implementation in JavaScript. Deprecated; use https://github.com/libp2p/js-libp2p-peer-id instead.
https://github.com/libp2p/js-libp2p-peer-id
MIT License
80 stars 44 forks source link

feat: async await #87

Closed hacdias closed 5 years ago

hacdias commented 5 years ago

More background about this effort: https://github.com/ipfs/js-ipfs/issues/1670.

~Despite some createX function not needing async, I added it to all of them to make them consistent. Otherwise we would have half returning a Promise and another half returning a PeerId~

hacdias commented 5 years ago

@alanshaw just made the updates 😄 I'll also take a look at peer-info later today!

hacdias commented 5 years ago

Done @alanshaw!

hacdias commented 5 years ago

@alanshaw should we re-do this or close?

achingbrain commented 5 years ago

Rebased & merge conflicts resolved. Just need a release of libp2p/js-libp2p-crypto with libp2p/js-libp2p-crypto#131 in it and this should be good to go.

alanshaw commented 5 years ago

Ready to merge \o/

alanshaw commented 5 years ago

Needs BREAKING CHANGE message in squash commit.

achingbrain commented 5 years ago

Commit message updated to have BREAKING CHANGE warning.

jacobheun commented 5 years ago

@pgte @daviddias can we get a minor release of this? 🙏

Perhaps it makes sense for @vasco-santos or I to take over lead maintainer on this, peer-info and peer-book?

daviddias commented 5 years ago

@jacobheun done :)

Perhaps it makes sense for @vasco-santos or I to take over lead maintainer on this, peer-info and peer-book?

It does! Thank you 👍🏽

jacobheun commented 5 years ago

0.13.0 is out and awaits you 😉