search

libp2p / js-peer-info

libp2p Peer abstraction Node.js implementation
https://libp2p.io
MIT License
37 stars 28 forks source link

Async Crypto Endeavour #22

Closed dignifiedquire closed 8 years ago

dignifiedquire commented 8 years ago

Ref https://github.com/libp2p/js-libp2p-crypto/pull/10

BREAKING CHANGE

New method PeerInfo.create(cb) replaces the previous new PeerInfo() to create a fresh id

daviddias commented 8 years ago

How did you solve the PCKS#1 vs PKCS#6. Can we confirm that we are manipulating and storing the keys in the same way as in go? This will be crucial for config file share, identify and secio crypto handshake.

dignifiedquire commented 8 years ago

How did you solve the PCKS#1 vs PKCS#6. Can we confirm that we are manipulating and storing the keys in the same way as in go? This will be crucial for config file share, identify and secio crypto handshake.

We already had tests for this (the go interop part) here and in libp2p-crypto. You can see the details of the conversion here: https://github.com/libp2p/js-libp2p-crypto/commit/eb5de1017be263a0344dd6358ec1ca17dea87d2a

daviddias commented 8 years ago
dignifiedquire commented 8 years ago

@diasdavid should be ready now