search

libp2p / js-peer-info

libp2p Peer abstraction Node.js implementation
https://libp2p.io
MIT License
37 stars 28 forks source link

fix(package): add missing lodash.uniqby dependency. #40

Closed haadcode closed 7 years ago

haadcode commented 7 years ago

Add lodash.uniqby to package.json as it's required by index.js

dignifiedquire commented 7 years ago

thanks lgtm

dignifiedquire commented 7 years ago

actually master uses lodash directly Oo can you please change that so it actually uses just this package?

haadcode commented 7 years ago

As far as I can tell it's only used in that one place: https://github.com/libp2p/js-peer-info/search?utf8=%E2%9C%93&q=lodash. Let me know if I'm missing something. If not, we're better off using the individual dep instead of pulling in whole of lodash as it gives us a smaller footprint (I know you know this :)).

dignifiedquire commented 7 years ago

yeah I meant if you can change the require to 'lodash.uniqby' instead of lodash

haadcode commented 7 years ago

Ah! :) Now I understand what you meant. Fixed, pushed and squashed.

daviddias commented 7 years ago

Nice, thank you for adopting our commit guidelines, @haadcode :)

merge and release as soon as CI becomes green