search

libp2p / jvm-libp2p

a libp2p implementation for the JVM, written in Kotlin 🔥
https://libp2p.io
Apache License 2.0
260 stars 74 forks source link

[GossipSub] Make sure no duplicates are sent to the same peer #370

Open Nashatyrev opened 1 month ago

Nashatyrev commented 1 month ago

Summary

It could potentially be the case when a message was propagated to a peer and we then receive IWANT from the same peer asking for the same message. We should at least add a unit test for this case

Expected behavior

No duplicates

Actual behavior

Probably duplicate

Relevant log output

No response

Possible Solution

No response

Version

No response

Would you like to work on fixing this bug ?

Maybe

Nashatyrev commented 1 month ago

Has been highlighted here: https://ethresear.ch/t/number-duplicate-messages-in-ethereums-gossipsub-network/19921/2