Add generic widget filter trays, simplifying filtering logic and table header UI

libp2p / observer-toolkit

🐣 [WIP] toolkit for building libp2p introspection widgets + a few useful out-of-the-box widgets

https://libp2p.io

MIT License

2 stars 2 forks source link

Add generic widget filter trays, simplifying filtering logic and table header UI #29

Closed AlanSl closed 4 years ago

AlanSl commented 4 years ago

Previously filters were applied to widgets in a quite bespoke way which required a lot of widget-specific logic and UI implementation. The new designs cut this out with a simpler filter tray that attaches widget-specific filters in a standard, simpler, more decoupled way.

Unfortunately implementing this involved a lot of changes, but it cuts out a lot of complexity so while this PR itself was quite painful it should save time in the long run.

AlanSl commented 4 years ago

This is updated against the amended version of https://github.com/nearform/libp2p-introspection-ui/pull/32 and has tests added for the new components, and should be ready to go.