libp2p / observer-toolkit

🐣 [WIP] toolkit for building libp2p introspection widgets + a few useful out-of-the-box widgets
https://libp2p.io
MIT License
2 stars 2 forks source link

Buffer event messages #55

Closed ovhemert closed 4 years ago

ovhemert commented 4 years ago

When ws server generates lot's of events, client/UI cannot handle that. This add's buffering of the ws messages and batch UI updates.

AlanSl commented 4 years ago

I've done some experimentation with this and posted a branch with some debugging logs, a crude size limit on the events table and some possible fixes to some issues I found here - https://github.com/nearform/libp2p-introspection-ui/commits/events-perf-test-unrebased

See the commit comment of the last commit https://github.com/nearform/libp2p-introspection-ui/commit/411a3b9bd8f47b0daa7730e8ecd75b6246884fcb - there are a few things here that I think are causing it to not work as intended:

With those changes it kinda works, though I'll still need to do a little on the UI side to simplify the animations as they are still getting bunched up.

AlanSl commented 4 years ago

So for next steps:

ovhemert commented 4 years ago

@AlanSl did some tests for perf. looking good with the max limit rendering, but think the planned buffering for files is not needed.

ovhemert commented 4 years ago

LGTM