Full-featured `identify` implementation

libp2p / py-libp2p

The Python implementation of the libp2p networking stack 🐍 [under development]

https://libp2p.io

Other

465 stars 101 forks source link

Full-featured `identify` implementation #358

Open ralexstokes opened 4 years ago

ralexstokes commented 4 years ago

We should reach feature-parity w/ the Go implementation of identify.

Some things missing:

[ ] Sharing our view of our local addresses

ShadowJonathan commented 4 years ago

What do you mean with that? That we are able to send local multiaddresses to remote peers when in the identify stage, or we send our view of their peer address when in the identify stage?

ralexstokes commented 4 years ago

@ShadowJonathan resolving this TODO: https://github.com/libp2p/py-libp2p/blob/master/libp2p/identity/identify/protocol.py#L33

following the semantics here: https://github.com/libp2p/go-libp2p/blob/master/p2p/protocol/identify/id.go#L307-L309

ShadowJonathan commented 4 years ago

Should just be an easy fix if the client can grab the current connecting peer's multiaddr