search

libp2p / rust-libp2p

The Rust Implementation of the libp2p networking stack.
https://libp2p.io
MIT License
4.38k stars 912 forks source link

kad: emit `ToSwarm::NewExternalAddrOfPeer` #5103

Open thomaseizinger opened 6 months ago

thomaseizinger commented 6 months ago

Description

With https://github.com/libp2p/rust-libp2p/pull/4371 merged, we have the foundation of https://github.com/libp2p/rust-libp2p/issues/4302 implemented.

libp2p-kad needs to be extended to emit this new event whenever it discovers a new address through the DHT.

Motivation

Other behaviours should be able to learn the addresses discovered by kademlia.

Current Implementation

Only kademlia knows about its discovered addresses.

Are you planning to do it yourself in a pull request ?

No

1010adigupta commented 6 months ago

would like to work on this

1010adigupta commented 6 months ago

would work on mDNS and DHT simultaneously, you can assign me this as well

thomaseizinger commented 6 months ago

would work on mDNS and DHT simultaneously, you can assign me this as well

Make them two PRs please! :)

justcode740 commented 5 months ago

unsure whether this one is taken but seem prev one has made such claim and not submit pattern in some other repo couple times..

thomaseizinger commented 5 months ago

You are welcome to work on this too!

blacktoast commented 3 months ago

Hi, do you mind if I try to do this?

I know a little bit of Rust, but this is my first time contributing to a p2p related library, so if you don't mind, is there any code or documentation that would help me solve this issue?

dariusc93 commented 2 months ago

@blacktoast are you still interested in tackling this issue?