search

libp2p / rust-yamux

Multiplexer over reliable, ordered connections.
Apache License 2.0
179 stars 43 forks source link

chore: remove `WindowUpdateMode::OnReceive` #175

Closed mxinden closed 11 months ago

mxinden commented 11 months ago

I suggest we remove WindowUpdateMode::OnReceive in favor of always using (not just defaulting to) WindowUpdateMode::OnRead.

I can not think of a use-case where one would want OnReceive over OnRead. Anyone?

Removing OnReceive will simplify our codebase.

https://github.com/libp2p/rust-yamux/blob/93b70626f7f3d83f97951d9cd5c2951500088f0d/yamux/src/lib.rs#L66-L76

thomaseizinger commented 11 months ago

Sounds good to me!

Perhaps make a point-release deprecating it first :)