search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.58k stars 275 forks source link

add identify/delta to identify spec #176

Closed yusefnapora closed 1 year ago

yusefnapora commented 5 years ago

This updates the spec to track the changes @raulk is adding in https://github.com/libp2p/go-libp2p/pull/659, which adds an identify/delta variant that only sends delta updates for protocol additions / removals (and maybe later, addresses). I'll keep this PR parked until the dust settles, but I figured I'd get a jump on it now.

@raulk am I correct that identify/push now always sends full updates?

jacobheun commented 5 years ago

Does this really need to be a separate protocol? I'm not seeing the need here aside from the concern about older peers breaking, in which case I feel like this should just become /ipfs/id/push/2.0.0. Adding delta is ultimately going to result in push no longer being used.

raulk commented 5 years ago

Does this really need to be a separate protocol?

Librarian note: conversation continued in https://github.com/libp2p/go-libp2p/pull/659#issuecomment-504451553 and onwards.

Stebalien commented 4 years ago

This protocol is strange.

@raulk or @vyzo?

Stebalien commented 4 years ago

Why doesn't this support updating addresses? Is the goal to use identify push for that and make this address only?

Nvm. This part won't matter once we get signed peer addresses anyways.

Stebalien commented 4 years ago

Proposed change: https://github.com/libp2p/specs/pull/253/files

aschmahmann commented 3 years ago

@raulk @Stebalien what's the state of this PR?

mxinden commented 1 year ago

Given that this effort has stalled and given that go-libp2p removed support for identify delta (https://github.com/libp2p/go-libp2p/pull/1975) I am closing here.

Please comment in case you disagree with the direction.