libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.58k stars 275 forks source link

Add WebRTC Transport Spec #220

Closed Stebalien closed 1 year ago

Stebalien commented 5 years ago

At the moment, we have three big issues communicating between go-libp2p and a browser:

  1. We can't dial them.
  2. We have to do our crypto in javascript.
  3. If the dApp is running in a secure origin, the go-libp2p node needs a valid TLS certificate for a valid domain.

However, it turns out that WebRTC already has built-in support for both encryption and multiplexing. Even better, the browser APIs allow the user to get the local and remote certificates of a connection (and their fingerprints).

Given this, we should be able to:

Setup

  1. Generate a certificate.
  2. Get the certificate's fingerprint.
  3. Sign this fingerprint using the libp2p peer key to generate a "peer cert"

Connection Establishment

  1. Create a connection with the certificate.
  2. Open a data stream.
  3. Send the "peer cert".
  4. Wait for the other side to do the same.
  5. Get the remote peer's TLS certificate.
  6. Check the remote endpoint's "peer cert".

Unfortunately, Firefox and Safari still need to implement https://www.w3.org/TR/webrtc/#dom-rtcdtlstransport-getremotecertificates.

mxinden commented 2 years ago

Moving a closed discussion into the open.

In order to (a) write a libp2p-webrtc specification and ultimately (b) support WebRTC across libp2p implementations, we need to investigate the following open questions:

_Where Browser is replaced with the major browsers of today (Chrome, Safari, Edge, Firefox)._

Direct connections

Securing the connection

Lifecycle of a WebRTC connection

Multiplexing

willscott commented 2 years ago

To respond to the 'Direct Connections' section, I believe it is possible: The SDP ICE candidate message itself does not contain any connection-specific information, and if you know the public ip:port of the other side you can craft it with just that information.

As a JS in-browser library, to initiate you would create a peer connection, and then pretend like you got a candidate from the other side by passing in such a hand-crafted SDP message. This will cause the browser to generate an answer SDP of it's own address, but also to attempt initiation of a direct webrtc connection to the remote host/port. If the listening peer is waiting for a connection (e.g. has opened a peer connection and made ice candidates), they will accept this connection. as it may come before the relayed ice answer would have even in a normal setup flow.

olanod commented 2 years ago

Chrome 97 adds support for WebTransport based on HTTP3 maybe worth considering as well?

aschmahmann commented 2 years ago

Chrome 97 adds support for WebTransport based on HTTP3 maybe worth considering as well?

From the link, I think we'll be out of luck here.

It has lower latency than WebSockets, and unlike the RTC Data Channel API, which is designed for peer-to-peer messaging, the Web Transport API is specifically designed for client-server messaging.

olanod commented 2 years ago

From the link, I think we'll be out of luck here.

You say it because of the client-server model? I think it would still be useful since it will be common for browser nodes connect to server nodes 🤔

aschmahmann commented 2 years ago

I think it would still be useful since it will be common for browser nodes connect to server nodes 🤔

Fair enough if the transport is better than websockets than it seems useful. However, the major benefit that WebRTC gives us is the ability to connect to a peer that does not have a domain name and TLS cert, which WebTransport does not help us with.

tomaka commented 2 years ago

To respond to the 'Direct Connections' section, I believe it is possible: The SDP ICE candidate message itself does not contain any connection-specific information, and if you know the public ip:port of the other side you can craft it with just that information.

One tricky point is going to be the fingerprint attribute. See https://datatracker.ietf.org/doc/html/rfc8122#section-5

Basically, each endpoint must include a hash of its self-signed certificate in the SDP message.

I haven't tried but I presume that browsers don't allow connections that don't use DTLS. I did try however to give a (DTLS) answer to the browser that does not include a fingerprint attribute, and the browser refuses the answer.

One solution could be to generate the certificate deterministically by using the PeerId as a seed. Unfortunately, this means that we would need to negotiate another encryption protocol (such as Noise) after establishing the WebRTC connection.

marten-seemann commented 2 years ago

Does Browser allow injecting properties into the certificate before the security handshake and thus carry the libp2p PeerId within the handshake data?

While it is possible to configure the certificates (in the RTCPeerConnection constructor), it's not possible to load them from file. There's a long discussion about that in https://github.com/w3c/webrtc-pc/issues/1853. In short, the reason people opposed an API that would allow importing of a cert / priv key is that would also allow the site to exfiltrate that key and then impersonate the user. As far as I can tell, certificates have to be generated using the generateCertificate method, which only allows configuration of the key generation algorithm and expiration time.

IdP looks like it might have offered a solution if we had managed to play a few cryptographic tricks and run our identity proxies, but I find it quite hard to find concrete information about this. This is probably due to the fact that this only supported by Firefox (see for example here). There's an unresolved Chrome issue from 2015, so we shouldn't put our hopes on this getting implemented any time soon.

mriise commented 2 years ago

Fair enough if the transport is better than websockets than it seems useful. However, the major benefit that WebRTC gives us is the ability to connect to a peer that does not have a domain name and TLS cert, which WebTransport does not help us with.

https://www.w3.org/TR/webtransport/#certificate-hashes Bootstrap nodes could hand out self generated certs to peers for communication with browsers. It doesn't fix peers that don't have regular communication with the nodes that can make valid certificates however. There could be an added spec to generate a cert on the fly and hand out to nodes a browser wishes to connect to, but that is more in the scope of adding WebTransport than WebRTC.

mxinden commented 2 years ago

WebRTC in libp2p - Ongoing Efforts

I want to highlight the many ongoing efforts around WebRTC in libp2p (that I am aware of). In the ideal case this enables some level of collaboration between the teams. Even if not, I think a general overview is in itself worth it.

mxinden commented 2 years ago

Note that I opened https://github.com/libp2p/specs/pull/412, consolidating all our findings thus far as well as listing open questions.

mxinden commented 2 years ago

Status Update

mxinden commented 1 year ago

Status Update

With both /webrtc (browser-to-browser) and /webrtc-direct (browser-to-server) specified and implemented, I am closing here as completed :tada: