search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Update circuitv2 to proto3 #511

Closed ckousik closed 1 year ago

ckousik commented 1 year ago

Updates the circuit v2 spec to use proto3. This closes #509.

p-shahi commented 1 year ago

Can you bump the revision (to r2) and date on line 7?

vyzo commented 1 year ago

Please ensure you are not breaking compatibility with existing nodes using the proto2 spec; that should be #1 priority in accepting such changes.

Also, perhaps you should consider plain fixing the offendant in this case, which is the js library that cant understand proto2 instead of trying to reengineer the world around it.

thomaseizinger commented 1 year ago

I'd like to include quick-protobuf in the experiments as we are currently transitioning to that in rust-libp2p. I'll report back with some results.

WIP here: https://github.com/MarcoPolo/proto3-and-2-compat-experiments/pull/1

MarcoPolo commented 1 year ago

quick-protobuf experiment looks good as well.

p-shahi commented 1 year ago

@achingbrain pinging for re-review