search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

fix(pubsub): remove "Implementation note" about setting `message_id_fn` #557

Closed cce closed 1 year ago

cce commented 1 year ago

This updates an old note in the message ID section of the pubsub spec to reflect that go-libp2p-pubsub currently supports topic-specific message ID configuration, using WithTopicMessageIdFn.

cce commented 1 year ago

Great! I wasn't sure if removing the paragraph was too drastic. I can do that too

cce commented 1 year ago

I removed the note — main reason for opening this PR was because I was reading the spec and go-libp2p-pubsub docs at the same time and noticed it wasn't up to date.

I think code organization would be the only difference between preferring a global message_id_fn that checks the topic, vs being able to set per-topic message_id_fns ... I found a whole discussion in https://github.com/libp2p/go-libp2p-pubsub/issues/464 about it