search

libp2p / test-plans

Interoperability tests for libp2p
https://libp2p.io
Other
45 stars 42 forks source link

stop testing mplex #196

Open marten-seemann opened 1 year ago

marten-seemann commented 1 year ago

mplex is being phased out. go-libp2p and rust-libp2p have removed it from the list of default muxers a long time ago. Kubo is considering removing it as well: https://github.com/ipfs/kubo/issues/9958.

p-shahi commented 1 year ago

Is it premature to stop testing mplex until this comment https://github.com/libp2p/specs/issues/553#issuecomment-1592857250 hold true and it's actually deprecated in the libp2p/specs?

The first step would be for every client to have yamux enabled by default (which requires stable support in their underlying libp2ps, and proper testing) Once that is done & we are confident in all yamuxes, we can update the specs to remove mandatory support

mplex also seems to acheive better performance than yamux: https://github.com/ChainSafe/js-libp2p-yamux/issues/42 in js-libp2p

marten-seemann commented 1 year ago

This is more about documenting what we're already doing now. We're not fixing bugs or performance issues in mplex, instead, we're already skipping tests (see the transport integration test effort in go-libp2p).

If we resolve the specs issue first and then disable the tests or vice versa will most likely not make any difference.