search

libp2p / website

Webpage of the libp2p project. A multi protocol approach for a interoperable network stack that follows the 'self description' in favor of assumptions
https://libp2p.io
36 stars 32 forks source link

chore: update impl table #172

Closed p-shahi closed 1 year ago

p-shahi commented 1 year ago

I think JS needs more than one column. Maybe at the minimum we have JS-Server, JS-Browser?

@BigLep split JS into two columns. Wanted to do this only for the transports column but the way the site generator works it needed to be applied to every column

(Probably not for transports but with JS we also need to be cognization of the context within the browser (e.g., main thread, worker)).

I think this is too granular for this table. I say we keep it as is.

Lets get a link to our testplans proving interoperability and what is supported (e.g., https://github.com/libp2p/test-plans/actions/runs/4854783650/attempts/1#summary-13154638397 )?

This will be kind of difficult to do in the current table format. Each of these modules/protocols links to the implementation on GitHub so we can't add a link to the interop test there.

I thought about adding a new table but even then, the link to the actual table is dynamically generated i.e. every CI run in the test-plans repo will create a new link. Since it'd have to be hardcoded in here and we don't have a long lived link, it'd get out of date quickly Do you have any thoughts on how it could be worked in? I think this is something we can address in a site redesign, but I'm finding it difficult to integrate it nicely as is

BigLep commented 1 year ago

@p-shahi : thanks. I took a quick scan at https://bafybeig52s6bdy4jlyn5blgkpni7scefbapubdenjssngfsgrc2zts57rq.on.fleek.co/implementations/ but I will let someone else who is closer to details approve.

Concerning surfacing interoperability tests, understood that we don't have a canonical link right now. I'll leave it to you guys on how to achieve this, but I am holding to the hope that someone comes to libp2p.io and gets an overwhelming sense of how seriously we take our pillars: security, interoperability, and performance. I want to make sure the work we're doing can be discovered and communicated in some form so that that sense is conveyed.

p-shahi commented 1 year ago

@mxinden addressed comments, thanks for the review!