search

libpcp / pcp

PCP client library
BSD 2-Clause "Simplified" License
69 stars 30 forks source link

Added handling for third party option (both library + sample client). #9

Closed fingon closed 10 years ago

fingon commented 10 years ago

I needed this to test my third party option changes to miniupnpd ;-) Works for me(tm).

BenderScript commented 10 years ago

Hi Markus,

can you post the results of your tests? Are you using the miniupnp with pcp support that we developed or you did you own changes to support PCP?

thanks,

Reinaldo

On Tue, May 13, 2014 at 4:53 AM, Markus Stenberg notifications@github.comwrote:

I needed this to test my third party option changes to miniupnpd ;-) Works

for me(tm).

You can merge this Pull Request by running

git pull https://github.com/fingon/pcp 3rd-party-option

Or view, comment on, or merge it at:

https://github.com/libpcp/pcp/pull/9 Commit Summary

  • Added handling for third party option (both library + sample client).

File Changes

  • M libpcp/include/pcp.hhttps://github.com/libpcp/pcp/pull/9/files#diff-0(2)
  • M libpcp/src/pcp_api.chttps://github.com/libpcp/pcp/pull/9/files#diff-1(11)
  • M libpcp/src/pcp_client_db.hhttps://github.com/libpcp/pcp/pull/9/files#diff-2(4)
  • M libpcp/src/pcp_msg.chttps://github.com/libpcp/pcp/pull/9/files#diff-3(16)
  • M pcp_app/pcp_app.chttps://github.com/libpcp/pcp/pull/9/files#diff-4(21)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/libpcp/pcp/pull/9 .

miniupnp commented 10 years ago

the PCP support for miniupnpd was merged :) It is now improved thanks to markus to support IPv6 firewall "pinholes".

fingon commented 10 years ago

The mainline miniupnpd is still missing some of the fixes from my pcp-ipv6 branch, but I'll try to make clean diff out of them at some point once it stops changing :)

I'm also working on actually fixing miniupnpd IPv6 socket handling in general (the patch is almost done, am testing it now on Linux) in a separate branch by migrating from sendto to sendmsg (allows setting e.g. explicit source address) and using recvmsg on IPv6 socket with IP6_RECV_PKTINFO. Given those, I think my PCP needs for my homenet case are mostly covered..