Closed tkirshboim closed 2 years ago
This looks great. I had to make the same changes to get it to build as well. This PR looks good.
Did you mean to delete those two test .java files?
Dan Wilcox danomatika.com robotcowboy.com
On May 17, 2022, at 1:12 PM, Seth @.***> wrote:
This looks great. I had to make the same changes to get it to build as well. This PR looks good.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
Did you mean to delete those two test .java files?
@danomatika Yes. Those were example test files that were not testing anything relevant for this repository.
The 'AblLinkSample' Android app no longer builds. This has been reported in #18 and #31 and this PR resolves both issues.
Validation
I was able to build and run the AblLinkSample app using this branch by doing the following:
--recursive
option when cloning).What was done
./gradlew wrapper
.pd-for-android
has a min SDK version of 17.30
and add a permission declaration toAndroidManifest.xml
to allow the app to run on Android API 30 devices and above.CMakeLists.txt
to align with changes that were introduced topd-for-android
folder structure in https://github.com/libpd/pd-for-android/pull/94 .