search

libpd / abl_link

Ableton Link integration for Pure Data on desktop and Android.
Other
80 stars 15 forks source link

Deken targets #8

Closed Ant1r closed 7 years ago

Ant1r commented 7 years ago

To help uploading to deken, this PR adds 2 targets : deken-source and deken-binary. These targets use git-describe to version the upload with latest git tag. Also include Makefile.pdlibbuilder in order to provide self-buildable github tarballs.

nettoyeurny commented 7 years ago

Confused now. This PR adds a copy of Makefile.pdlibbuilder to the external directory, but then it doesn't delete the pd-lib-builder submodule, and the Makefile still seems to use the copy in the pd-lib-builder directory.

I think it makes sense to just add a copy of Makefile.pdlibbuilder, but then let's get rid of the submodule and have the Makefile use the local copy.

danomatika commented 7 years ago

I agree. One or the other.

Better solution IMO is to disavow Github tar balls and add a script to build he tarball which essentially does a checkout of the repo and it's submodules, then zips/tars things up. Then add a note in the readme not to use the GH download links. I do this in my projects where tar balls are important as I feel this is a prob with GH itself.

Ant1r commented 7 years ago

The point was to enable the use of the tarball for automated script like debian packagers, requested by IOhannes. That's why that solution enables this, while allowing to work on a fresh pdlibbuilder. But I agree the submodule could got rid of, using another way to import a fresh Makefile.pdlibbuilder.

danomatika commented 7 years ago

Ok, then I'd say remove the submodule. We'll just need to make sure pdlibbuilder is up to date now and then.

danomatika commented 7 years ago

pinging @umlaeute what do you think?

umlaeute commented 7 years ago

i think: either use a submodule XOR include the Makefile.pdlibbuilder.

i'd rather still include the PDLIBBUILDERDIR variable though, so make it something like:

PDLIBBUILDER ?= .
include $(PDLIBBUILDERDIR)/Makefile.pdlibbuilder
nettoyeurny commented 7 years ago

The revised Makefile already included the PDLIBBUILDERDIR variable, so it looks like we're all on the same page. I'll merge this PR, then.