search

libpd / pd-for-android

Pure Data for Android
353 stars 91 forks source link

Update PdService.java #120

Open rafaelgustavo123 opened 2 years ago

rafaelgustavo123 commented 2 years ago

PendingIntent bug on android 12. Please, add this changes.

joebowbeer commented 2 years ago

Fixes #121 ?

joebowbeer commented 2 years ago

See SO for background and link to article: https://stackoverflow.com/q/67045607/901597

joebowbeer commented 2 years ago

@tkirshboim our git submodules are not syncing due to deprecated protocol as reported #118

Deprecation: https://github.blog/2021-09-01-improving-git-protocol-security-github/

I created a test PR #122 but it is failing further along; we also need to update our link to libpd in order to pickup the .gitmodules changes there.

https://github.com/libpd/libpd/commit/df45c75f65ea495813e24c907870eeb0660f813e

Still working on fixing the build. Now stuck on some recently added double precision support...

rafaelgustavo123 commented 2 years ago

Fixes #121 ?

yes!

cerupcat commented 2 years ago

Is there any additional work to be done here? I'm aiming to get this up and running on 31+ so would like to help get this merged in if it's ready.

tkirshboim commented 2 years ago

@cerupcat This still needs to be done.

FunkyMuse commented 2 years ago

@cerupcat This still needs to be done.

As I can see that the question is whether to keep the zero or not, in this case it's smarter to keep the zero because you do not have any custom request code meaning zero is no request codes at all, unless the service does something specific and obtains it through that request code then and only then it makes sense to have it custom one.

FunkyMuse commented 1 year ago

hey guys, any chance on getting this merged?

cerupcat commented 1 year ago

@joebowbeer @tkirshboim Any chance we can get this merged? We're like to integrate this change.

joebowbeer commented 1 year ago

@cerupcat This PR looks good to me, but the build fails.

@tkirshboim I think we're still stuck on https://github.com/nettoyeurny/opensl_stream/issues/5 via https://github.com/libpd/libpd/pull/357

Ideas?

FunkyMuse commented 1 year ago

@cerupcat This PR looks good to me, but the build fails.

@tkirshboim I think we're still stuck on nettoyeurny/opensl_stream#5 via libpd/libpd#357

Ideas?

I'm not sure how they're related 🤔

This is only a flag to prevent crashes when it comes to the service

tkirshboim commented 1 year ago

This also still needs to be done. @rafaelgustavo123 Could you take a look?

joebowbeer commented 1 year ago

@FunkyMuse writes

This is only a flag to prevent crashes when it comes to the service

Until the build is fixed, I guess the other option would be to make a point release based on an older tag.

FunkyMuse commented 1 year ago

@FunkyMuse writes

This is only a flag to prevent crashes when it comes to the service

Until the build is fixed, I guess the other option would be to make a point release based on an older tag.

It'll be of a great help, since targeting newer SDKs is a requirement from Google nowadays

FunkyMuse commented 1 year ago

@FunkyMuse writes

This is only a flag to prevent crashes when it comes to the service

Until the build is fixed, I guess the other option would be to make a point release based on an older tag.

can we get a release, I can see the PR is merged for https://github.com/libpd/pd-for-android/pull/126

joebowbeer commented 1 year ago

@FunkyMuse writes

This is only a flag to prevent crashes when it comes to the service

Until the build is fixed, I guess the other option would be to make a point release based on an older tag.

can we get a release, I can see the PR is merged for #126

It may be a while before we release to maven central, but there is a recent snapshot build

https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/libpd/android/pd-core/1.2.1-SNAPSHOT/

And the aar artifact can be downloaded from the GitHub Action:

https://github.com/libpd/pd-for-android/actions/runs/5283412584

Perhaps one of these will work in the interim?

cerupcat commented 1 year ago

It appears that snapshot also has the crash issue.

joebowbeer commented 1 year ago

It appears that snapshot also has the crash issue.

What crash issue?

The current code now provides FLAG_IMMUTABLE, right?

Is the error message still the same?

FunkyMuse commented 1 year ago

It appears that snapshot also has the crash issue.

What crash issue?

The current code now provides FLAG_IMMUTABLE, right?

Is the error message still the same?

yeap, tried with every version from https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/libpd/android/pd-core/1.2.1-SNAPSHOT/

joebowbeer commented 1 year ago

@rafaelgustavo123 can you confirm this PR is no longer needed and close it?

@cerupcat @FunkyMuse can you open an issue for your crash?

Is it one of these crashes?

cerupcat commented 1 year ago

@FunkyMuse can you help provide more information on the crash you're seeing?

FunkyMuse commented 1 year ago

@rafaelgustavo123 can you confirm this PR is no longer needed and close it?

@cerupcat @FunkyMuse can you open an issue for your crash?

Is it one of these crashes?

It's the FLAG_IMMUTABLE crash

rafaelgustavo123 commented 1 year ago

Should I close it?

joebowbeer commented 1 year ago

The immutable flag is in the main branch:

https://github.com/libpd/pd-for-android/blob/master/PdCore/src/main/java/org/puredata/android/service/PdService.java#L244

I've confirmed that this change is in the source code of the latest snapshot.

@rafaelgustavo123 please close this PR or rebase on the main branch

@cerupcat @FunkyMuse Please create a new issue with details

NOTE: Make sure you update the cache

https://stackoverflow.com/questions/13565082/how-can-i-force-gradle-to-redownload-dependencies