libpd / pd-for-android

Pure Data for Android
351 stars 91 forks source link

Publish the library to a public maven repository #20

Closed tkirshboim closed 8 years ago

tkirshboim commented 8 years ago

That repository will probably be jcenter

tkirshboim commented 8 years ago

As an maven artifact id me and @joebowbeer thought of using:

org.puredata.android:pd-core:1.0.0

Pinging @nettoyeurny @chr15m @danomatika - any thoughts on this?

danomatika commented 8 years ago

Since it's android only, why not org.puredata.android:libpd:1.0.0

joebowbeer commented 8 years ago

libpd reminds me of the.so libpd contained therein, but maybe I know too much

On Wed, Nov 18, 2015 at 1:04 PM, Dan Wilcox notifications@github.com wrote:

Since it' android only, why not org.puredata.android:libpd:1.0.0

Reply to this email directly or view it on GitHub: https://github.com/libpd/pd-for-android/issues/20#issuecomment-157863007

nettoyeurny commented 8 years ago

I think libpd is potentially ambiguous because it sometimes refers to the underlying C library and sometimes to the platform-specific bits as well. Since the platform-specific project for Android is called PdCore, it makes a lot of sense to call the maven artifact pd-core.

On Wed, Nov 18, 2015 at 4:19 PM, Joe Bowbeer notifications@github.com wrote:

libpd reminds me of the.so libpd contained therein, but maybe I know too much

On Wed, Nov 18, 2015 at 1:04 PM, Dan Wilcox notifications@github.com wrote:

Since it' android only, why not org.puredata.android:libpd:1.0.0

Reply to this email directly or view it on GitHub: https://github.com/libpd/pd-for-android/issues/20#issuecomment-157863007

— Reply to this email directly or view it on GitHub https://github.com/libpd/pd-for-android/issues/20#issuecomment-157866603 .

tkirshboim commented 8 years ago

Status: published an RC1 version on Bintray - waiting for approval to be added to jcenter: https://bintray.com/pd-for-android/maven/pd-for-android/1.0.0-rc1/view

tkirshboim commented 8 years ago

JCenter approved the request. pd-for-android is now publicly available as an Android library the standard Android way. :tada: I'm leaving this ticket open until we've updated the documentation with explanation how to use the library this way. But briefly- what was until now:

dependencies {
    compile project(':PdCore')
}

can be replaced with :

dependencies {
    compile 'org.puredata.android:pd-core:1.0.0-rc1'
}

(assuming that the project uses jcenter to resolve maven dependencies)

deepkanwal commented 8 years ago

I'm getting the following error when attempting a Gradle sync using compile 'org.puredata.android:pd-core:1.0.0-rc1' with a new empty project.

Error:Failed to resolve: com.github.nettoyeurny:btmidi:9bc54ccbe1

Any ideas?

tkirshboim commented 8 years ago

@deepkanwal looks like I was too eager to celebrate.. The RC1 version requires the jitpack repository, which is not what we want. I didn't notice that I had it in my test setup. Sorry about that and thanks for the letting us know. I'll fix this and update the issue here.

tkirshboim commented 8 years ago

@deepkanwal I have fixed this and released a new version that you can use with:

dependencies {
    compile 'org.puredata.android:pd-core:1.0.0-rc2'
}

Let me know if this for some reason still doesn't work for you. Thanks!

tkirshboim commented 8 years ago

Update: We still have issues with publishing the library on JCenter. The 'rc2' release mentioned above might work for you, but until we have AndroidMidi published on Jcenter as well it's probably better to use Jitpack as described here: https://jitpack.io/#libpd/pd-for-android/v1.0.0-rc3

luizmello commented 8 years ago

Hi, I just test the Jitpack (rc3) repository and it works with no errors. You are doing a great job here! thanks a lot for creating this method with repositories, this is much faster and simple.

tkirshboim commented 8 years ago

@luizmello thanks! Glad to hear that it's working :)

tkirshboim commented 8 years ago

I just released version '1.0.0-rc3' on Jcenter which uses AndroidMidi from JCenter as well: https://bintray.com/pd-for-android/maven/pd-for-android/1.0.0-rc3/view

Please try it out if you have a moment and see #27 for more details. Thanks!