search

libpd / pd-for-ios

Pure Data for iOS
Other
265 stars 72 forks source link

abl_link: deken package misses Makefiles #11

Closed umlaeute closed 7 years ago

umlaeute commented 7 years ago

thanks for sharing [abl_link~] via deken.

however the deken-file lacks the Makefile to build the external.

please provide it in future uploads.

nettoyeurny commented 7 years ago

I'm a bit fuzzy on what goes into distributing sources via deken. Does this require any changes to files in this repo or is it just a matter of repackaging the source distribution? In any case, I'll close this issue here. Feel free to open a new issue against the new repo if there's anything I need to change on my side. (I'm not currently set up to upload anything to puredata.info, so it would be great if you would take care of that.)

umlaeute commented 7 years ago

a (Sources) deken-package should allow to (re)build the library (exactly), s oit should be self-contained.

basically this includes the sources and the build-system.

i would not include any third party libs (like ableton_link), but it would be good to include documentation on how to obtain (which version) of any 3rd party library. (my rule of thumb is: everything that is a git-submodule should not be included)

nettoyeurny commented 7 years ago

Of course, but my question was whether the missing Makefile was due to some issue with this repository (e.g., should the Makefile specify itself as a data file to be packaged for deken?) or is this just a matter of manually rebuilding the deken package to include the Makefile that doesn't require any changes to this repo?

umlaeute commented 7 years ago

since I do not know how you created the deken package, I have no clue why some files are missing from it.

nettoyeurny commented 7 years ago

The thing is, I didn't create the deken package myself. My question remains, though --- is there a preferred way to automate the creation of the source package (analogous to the way that pd-lib-builder stages binaries and help patches for deken), or is this orthogonal to the code in the abl_link repo? If it's the former, I'll be happy to make the necessary code changes. If it's the latter, then this is the wrong place for this conversation and the way to resolve this is to just post a new source package.

umlaeute commented 7 years ago

i don't think that there is a preferred way to build the deken package.

Using the deken tool, it will (should) detect all the archs (including Source) but it will not ensure that the resulting package is usable in any way (including the possibility to build).

there's a ticket for pd-lib-builder to add a deken-source target, but afaik it is not functional yet (at least it is not included in the current releases).

So you could add something to your repo to create a proper deken source package. you could also decide not to.

I reported the issue here, because i haven't found a better place. (after all, it was @nettoyeurny who announced the deken package on the Pd-list, making it kind of official, even though @Ant1r did the upload)

nettoyeurny commented 7 years ago

Thanks, @umlaeute ! @Ant1r graciously agreed to update the source package, so this issue will be taken care of soon.