search

libprima / PRIMA.jl

a Julia interface to PRIMA, a Reference Implementation for Powell's methods with Modernization and Amelioration
MIT License
21 stars 5 forks source link

Add non-linear equality constraints in COBYLA #17

Closed emmt closed 1 year ago

emmt commented 1 year ago

This PR fixes issues:

emmt commented 1 year ago

@zaikunzhang and @amontoison: Can you have a look at this PR before I merge it?

The musl Linux tests failed because of insufficient credits...

amontoison commented 1 year ago

@zaikunzhang and @amontoison: Can you have a look at this PR before I merge it?

I suggest to add a reference to the Julia package NOMAD.jl.

The musl Linux tests failed because of insufficient credits...

I checked the logs and we have some StackOverflowError. For information, we have unlimited credits with CirrusCI if the repository is public @emmt.

emmt commented 1 year ago

I checked the logs and we have some StackOverflowError. For information, we have unlimited credits with CirrusCI if the repository is public @emmt.

You are right, I read the log files too quickly. Sorry!

Yet I do not see why StackOverflowError only arises on the musl Linux platform. In Julia, this kind of error is usually the sign of an infinite function call recursion. I will investigate that.

emmt commented 1 year ago

I suggest to add a reference to the Julia package NOMAD.jl.

Good idea! Done in https://github.com/libprima/PRIMA.jl/pull/17/commits/a73f854a193217f0893a1f7893d42c868c3d7af7 of this PR.

zaikunzhang commented 1 year ago

Thank you @emmt and @amontoison . I give some comments at https://github.com/libprima/PRIMA.jl/issues/14 for your consideration. In particular, https://github.com/libprima/PRIMA.jl/issues/14#issuecomment-1772347227

BTW, due to some urgent deadlines, I will be almost away from GitHub until the end of the month. Thank you for your understanding.

amontoison commented 1 year ago

@emmt Should we remove Linux MUSL from CI?

emmt commented 1 year ago

@amontoison yes we should perhaps do that because Linux musl is not recommended (on Julia download page) for production use. The StackOverflow error my arise from issues not in PRIMA.jl code.

emmt commented 1 year ago

Issue #4 is solved by this PR.

The only remaining issues are the check-spelling ones.

emmt commented 1 year ago

All tests passed. I merge this PR and will trigger a new version (0.2.0) since the API has changed quite substancially...