search

libprima / prima

PRIMA is a package for solving general nonlinear optimization problems without using derivatives. It provides the reference implementation for Powell's derivative-free optimization methods, i.e., COBYLA, UOBYQA, NEWUOA, BOBYQA, and LINCOA. PRIMA means Reference Implementation for Powell's methods with Modernization and Amelioration, P for Powell.
http://libprima.net
BSD 3-Clause "New" or "Revised" License
304 stars 40 forks source link

fork scheduled workfows #93

Closed jschueller closed 11 months ago

jschueller commented 1 year ago

each fork of prima runs scheduled workflows on its own, thats unnecessary and may slow users own workflows

this is a known issue https://github.com/orgs/community/discussions/16109

the solution would be adding a condition for each job: if: github.repository == 'libprima/prima'

zaikunzhang commented 1 year ago

Hi @jschueller ,

Apologies for the late response.

I agree that it is an issue. It would be desirable if there was a systematic way to specify the repo where a workflow should run. However, doing it on the job level seems not ideal.

The solution I suggest for the moment is to disable the workflow manually.

Also, I would like to remark that all workflows with a cron schedule are disabled by default on forks according to GitHub's documentation:

Warning: To prevent unnecessary workflow runs, scheduled workflows may be disabled automatically. When a public repository is forked, scheduled workflows are disabled by default.
jschueller commented 1 year ago

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too slowing down my own jobs from my other repos

zaikunzhang commented 1 year ago

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too slowing down my own jobs from my other repos

There is probably a bug on the GitHub side. I also experienced that some scheduled workflows are enabled unintendedly, but I cannot reproduce the problem. If you can, you may report to GitHub.

For the moment, the solution is to disable the workflows manually.

Thank you.

jschueller commented 1 year ago

the issue has been reported: https://github.com/orgs/community/discussions/16109 the solution is to explicitely disable it via a job condition: https://github.com/libprima/prima/pull/94

zaikunzhang commented 1 year ago

I guess it had been reported before GitHub implemented "disable scheduled workflows on forks by default".

The (new) problem is that the implementation seems not always working.

Thanks.

jschueller commented 11 months ago

seems its disabled now on new forks

zaikunzhang commented 11 months ago

Great. Thanks.

I still observe from time to time that they are enabled on some forks. But I have not recognized the pattern yet. So do not be surprised if they come back ...