libqueso / queso

QUESO is a C++ library for doing uncertainty quantification. QUESO stands for Quantification of Uncertainty for Estimation, Simulation and Optimization.
Other
57 stars 40 forks source link

Use GammaRV prior for truncation_error_precision #596

Closed roystgnr closed 7 years ago

roystgnr commented 7 years ago

This gives us the default shape/scale values we want, and the options infrastructure to change them, and sets up a proper gamma prior with those values instead of an improper uniform prior.

This fixes more of the issues noted in #511

codecov[bot] commented 7 years ago

Codecov Report

Merging #596 into dev will increase coverage by <.01%. The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #596      +/-   ##
==========================================
+ Coverage   71.34%   71.34%   +<.01%     
==========================================
  Files         167      167              
  Lines       14477    14490      +13     
==========================================
+ Hits        10328    10338      +10     
- Misses       4149     4152       +3
Impacted Files Coverage Δ
src/gp/src/GPMSAOptions.C 72.51% <50%> (+1.09%) :arrow_up:
src/gp/src/GPMSA.C 81.48% <57.14%> (-0.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e1c560...89601c5. Read the comment docs.

roystgnr commented 7 years ago

Should be okay now.