search

libracore / WooCommerceConnector

Integration App for ERPNext to connect to WooCommerce
Other
85 stars 149 forks source link

Rename DocType and enable product syncing. #23

Closed carstenblt closed 4 years ago

carstenblt commented 4 years ago

For most people the DocType name still isn't working, including me. This simply renames it to "WooCommerce Config" which should eliminate all problems.

It also has some fixes to enable product syncing again. However I removed all WC -> ERPNext syncing, as this probably needs more work - and I guess most people don't necessarily need it.

Image upload is now implemented solely by using the public URL. That means private images don't work this way. Uploading image data would need more work as you have to use the WP API which apparently needs a different authentication.

Anyways, this is what I needed to do to be able to start using the app. It would be great to have this in your repository.

lasalesi commented 4 years ago

Thanks for your input. Let me have a look into this and revert back. "WooCommerce Config" rather than "WooCommerce Settings" seems to be a workaround rather than a solution... What was the issue with product sync?

carstenblt commented 4 years ago

I believe having the same name as the core DocType is the issue, so renaming it is the solution. Identical names are calling for a conflict to happen.

The script wouldn't create items that were in ERPNext. Because the line was commented out and also because the code had some bugs - e.g. a broken SQL query.