search

libraries-fi / kirkanta

Administrator interface for Kirjastohakemisto, the Finnish Library Database
MIT License
1 stars 2 forks source link

Wishlist: Add images to CKEditor #7

Open olli-suutari-jkl opened 5 years ago

olli-suutari-jkl commented 5 years ago

In Jyväskylä, we have been experimenting with images in descriptions, e.g. https://www.jyvaskyla.fi/kirjasto/kirjastot?jyvaskylan-paakirjasto?lapset-ja-nuoret https://www.jyvaskyla.fi/kirjasto/kirjastot?jyvaskylan-paakirjasto?lukupysakki

Images can currently be added to the CKEditor by copy-pasting them from somewhere else, this however is not very user friendly.

I think it would be great, if the CKEditor's image tool would be made available in Kirkanta. https://ckeditor.com/docs/ckeditor4/latest/guide/dev_image.html

Uploading images to Kirkanta servers wouldn't be necessary since they could be uploaded to somewhere else and just linked to the editor.

sjuvonen commented 5 years ago

There are security concerns if we were to allow linking to external images. Since the data is also used on Finna and Helmet.fi and also support for exporting to Suomi.fi is under progress, I think we should really avoid any "dumb" risks.

Remote content allows for example tracking users (and traffic to websites displaying those images) if not injecting viruses.

However, I think it would be possible to allow users to upload images to be used within the description text. Maybe the simplest solution would be to just make users upload photos in the Photos section and provide a mechanism to linking to those images "internally".