search

librariesio / bibliothecary

:notebook_with_decorative_cover: Libraries.io Package Manager Manifest Parsers
https://libraries.io/rubygems/bibliothecary
GNU Affero General Public License v3.0
92 stars 36 forks source link

Add pip parsing to conda environment yaml files #499

Closed jsonperl closed 3 years ago

jsonperl commented 3 years ago

Trying out a bit of a hybrid approach where we rely on conda-parser for the primary conda bits, and then added some of the previous code back for parsing pip-in-conda dependencies. I have to dig in a little more here, because I don't think Bibliothecary#analyse_file should be producing an array.

I'm wondering if we should have the pypi parser do this and figure out some way to let both parsers have at the file.

tyrelsouza commented 3 years ago

I don't think Bibliothecary#analyse_file should be producing an array.

I feel like I agree, I remember we added that to support something, and then ripping out pip support for conda we were able to make it a single object vs an array.

jsonperl commented 3 years ago

This allows multiple environments to claim a single file as applicable. Now pypi can process environment.yml files if they happen to contain pypi packages.