search

librariesio / bibliothecary

:notebook_with_decorative_cover: Libraries.io Package Manager Manifest Parsers
https://libraries.io/rubygems/bibliothecary
GNU Affero General Public License v3.0
89 stars 36 forks source link

Recurse "dependencies" in package-lock.json to fully capture all deps. #520

Closed tiegz closed 2 years ago

tiegz commented 2 years ago

Bibliothecary doesn't currently descend into each NPM dependency's "dependencies" objects, which means it's missing nested deps, such as deps that are required via multiple versions.

This starts recursing into those nested objects to fully fetch all the deps, which means clients of Bibliothecary may start seeing more deps from "package-lock.json" files now.

tyrelsouza commented 2 years ago

Seems easy enough, breaking out a recursive function to a new function, and calling it in the old place. ✔️