librariesio / bibliothecary

:notebook_with_decorative_cover: Libraries.io Package Manager Manifest Parsers
https://libraries.io/rubygems/bibliothecary
GNU Affero General Public License v3.0
89 stars 36 forks source link

Fix error for missing fields in dependencies.csv parser #528

Closed tiegz closed 2 years ago

tiegz commented 2 years ago

When a dependencies.csv has a blank field, we were check for emptiness without checking for nilness first:

Before

{:dependencies=>nil, :error_message=>"dependencies.csv: undefined method `empty?' for nil:NilClass", :kind=>"lockfile", :path=>"dependencies.csv", :platform=>"generic", :success=>false}

After

{:dependencies=>nil, :error_message=>"dependencies.csv: missing field 'requirement' on line 1", :kind=>"lockfile", :path=>"dependencies.csv", :platform=>"generic", :success=>false}