librariesio / bibliothecary

:notebook_with_decorative_cover: Libraries.io Package Manager Manifest Parsers
https://libraries.io/rubygems/bibliothecary
GNU Affero General Public License v3.0
89 stars 36 forks source link

Standardize on _REGEXP names over _REGEX #586

Closed tiegz closed 8 months ago

tiegz commented 8 months ago

small style change: we should use _REGEXP as a suffix for constants instead of _REGEX so that the code is consistent and because Ruby's regular expression class is called Regexp.

(I considered keeping the old constants as deprecated constants and removing them in a later major version, but since we don't keep a CHANGELOG and we don't really do big major version releases, the result will be the same: downstream users will just be alerted that a constant they use is missing and they'll have to refer to the gem)