Closed djpowers closed 1 year ago
This slightly reworks the changes introduced in #3174.
The previous PR does updates the homepage_url value used, but that is not ultimately used to set the Project#homepage value: https://github.com/librariesio/libraries.io/blob/456440d4ece34fdc96965ddaa36da2b9fcdaa36e/app/models/package_manager/pypi/json_api_project.rb#L106
homepage_url
Project#homepage
The homepage_url value is only passed into the repo_fallback method, which is used to set the repository_url.
repo_fallback
repository_url
I don't see a need to distinguish between the homepage and homepage_url methods, so this consolidates them.
homepage
This slightly reworks the changes introduced in #3174.
The previous PR does updates the
homepage_urlvalue used, but that is not ultimately used to set theProject#homepagevalue: https://github.com/librariesio/libraries.io/blob/456440d4ece34fdc96965ddaa36da2b9fcdaa36e/app/models/package_manager/pypi/json_api_project.rb#L106The
homepage_urlvalue is only passed into therepo_fallbackmethod, which is used to set therepository_url.I don't see a need to distinguish between the
homepageandhomepage_urlmethods, so this consolidates them.