librariesio / libraries.io

:books: The Open Source Discovery Service
https://libraries.io
GNU Affero General Public License v3.0
1.11k stars 203 forks source link

chore: Upgrade Libraries to Rails 6.0 #3186

Closed macowie closed 1 year ago

macowie commented 1 year ago

The goal of this PR is to take the first step towards getting the application updated to a supported version of Rails. To the degree that it is doable (and/or convenient), hold off on configuration changes and other updates until after we get there.

The elasticsearch gem versions we were using are still compatible, so I didn't touch them. I had a look at the code that interacts with them and don't see anything that should be affected by the upgrade. My local indices continued to work and in all the tests and my spot checking seems to be fine. As long as we have backups of production's indices, I don't see much risk here.

I did a fair amount of manual testing to look for any unexpected bugs and make sure the user facing things were working and one template glitch aside, it seemed good to me. Others are more than welcome to bang on it, though.