search

librariesio / libraries.io

:books: The Open Source Discovery Service
https://libraries.io
GNU Affero General Public License v3.0
1.1k stars 206 forks source link

Version: replace most in-Ruby sorting #3275

Closed mpace965 closed 6 months ago

mpace965 commented 6 months ago

Some projects with many versions (several thousand) will take quite a while to render the Project show page. Sort Versions by number in SQL where possible. Limit the semver diff behavior on number of Versions.

mpace965 commented 6 months ago

This spec doesn't look like it should be passing in the first place, but I can't reproduce the failure locally. It looks nominally related to my changes (in that the failure has to do with Versions), but I don't understand why it would cause this expectation to suddenly start failing

https://app.circleci.com/pipelines/github/librariesio/libraries.io/2046/workflows/414f4839-8b3e-40c6-a28b-a09028565d96/jobs/6367/tests

Looks like changing it to match_array or something would fix it